[MRG] FIX put back nca's tests #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdevazelhes
pushed a commit
to wdevazelhes/metric-learn
that referenced
this pull request
Jan 2, 2019
|
It should be good to merge now. Basically it is just the same tests that were introduced in #99, but here I just also remove the learning rate deprecation test, and I change the tests to use |
|
Thanks, let's merge |
bellet
pushed a commit
that referenced
this pull request
Jan 2, 2019
* API: remove num_labeled parameter * DEP: Add deprecation warnings for num_labels * MAINT: put deprecation for version 0.5.0 * Revert "MAINT: put deprecation for version 0.5.0" This reverts commit 8727c44. * Revert "Merge remote-tracking branch 'origin/master' into fix/remove_num_labeled_parameter" This reverts commit 944bb3e, reversing changes made to 8727c44. * Revert "Revert "MAINT: put deprecation for version 0.5.0"" This reverts commit bc1eb32. * FIX string representation test wrongly merged * git revert d6bd0d4 * STY fix pep8 errors * STY: fix docstring indentation * FIX remove tests from NCA that are dealt with in #143 * FIX remove nca deprecation test because we remove totally learning rate in the merge #139 * FIX update version * Remove the use of random_subset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts back tests on NCA that were put in #99, but that I deleted unintentionnaly in PR #139