[MRG] change bounds parameter of ITML_Supervised from init to fit #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 23, 2019 14:51
…ious deprecation tests names
# Conflicts: # metric_learn/sdml.py
# Conflicts: # metric_learn/itml.py
|
Good ! The diff is clean now, so we can merge this |
bellet
approved these changes
Jan 29, 2019
Good idea ! I didn't know about that, this draft option is great to add changes gradually as they are done :) Allright I'll document changes there from now on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts the
boundsparameter in fit rather that init in ITML's supervised version, because it is data dependent (see comment #159 (comment))This PR starts from PR #159, so we should merge #159 first, to have a clean diff