-
Notifications
You must be signed in to change notification settings - Fork 228
Fix failing tests in last build #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing tests in last build #270
Conversation
The warning raised in the failing tests is from sklearn (see scikit-learn/scikit-learn#14545):
It should be fine for us to simply remove the passed attributes. Will do |
Removing the passed attributes does make the Python > 3.4 tests pass but makes the other fail, as sklearn dropped support for Python < 3.5. One way to fix this would be to keep the attributes and relax the tests to let this particular warning go through, but this will make the code break when sklearn releases its next version. So I would favor a solution based on checking Python version with BTW this is an example of the problems we are likely to see more and more as we continue to support Python < 3.5 while sklearn does not. I think we should also drop support for Python < 3.5 in the next release, see also discussion in #166 |
I implemented the strategy proposed above and all tests are now passing, so I think it is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
The problem is due to a deprecation warning for
check_is_fitted
in the new version of sklearn (see below)This PR fixes this by not using the attributes argument when calling
check_is_fitted
.