[MRG] Allow installation from conda #283

bellet · 2020-03-30T10:33:55Z

Anaconda is widely used so it would be nice to be able to install metric-learn with conda install. After a bit of research I think the best option is to add metric-learn to the popular conda-forge channel instead of creating a specific channel

I have created the recipe and PR there: conda-forge/staged-recipes#11168

@perimosocordiae @terrytangyuan @wdevazelhes I put you in the list of maintainers, so you have to post a comment on the above PR to let them know that you are willing to be listed there

Note: I also noticed that the PyPi entry is somewhat outdated, for instance the badges for travis and codecov do not work probably due to outdated URL. metric-learn appears in the "My projects" section but the "manage" button is greyed out. Can someone give me the management rights and/or fix the small problems in the PyPi entry? Thanks!

perimosocordiae · 2020-03-30T11:54:19Z

I commented on the conda PR. Thanks for setting this up!

terrytangyuan · 2020-03-30T12:25:49Z

Thanks. This looks great!

bellet · 2020-03-31T08:38:46Z

As requested in the conda-forge PR, I modified setup.cfg to include the license file to future source distributions. I checked locally and it works when running python setup.py sdist

synapticarbors · 2020-03-31T13:39:23Z

@bellet If you checked that the entry in setup.cfg works, that's great. I had a hard time finding explicit documentation. In the past I've always suggested including a MANIFEST.in with the proper entry:

https://packaging.python.org/guides/using-manifest-in/#using-manifest-in

but if the setup.cfg route works, that's obviously fine too.

bellet · 2020-03-31T13:48:05Z

@bellet If you checked that the entry in setup.cfg works, that's great. I had a hard time finding explicit documentation. In the past I've always suggested including a MANIFEST.in with the proper entry:

https://packaging.python.org/guides/using-manifest-in/#using-manifest-in

but if the setup.cfg route works, that's obviously fine too.

Yes, I read about both solutions. I checked on my local machine and the added line in setup.cfg works (the tarball does contain the license file after the change). But I don't know how robust this behavior is. @perimosocordiae @terrytangyuan @wdevazelhes maybe you guys can give it a try on your local machine? Otherwise we can also add a MANIFEST.in file with the appropriate entry

terrytangyuan · 2020-03-31T13:54:02Z

@bellet @synapticarbors I think adding it in setup.cfg has the same effect (reference). It works for me locally.

terrytangyuan · 2020-03-31T13:57:17Z

README.rst

@@ -33,6 +33,8 @@ metric-learn contains efficient Python implementations of several popular superv

 Run ``pip install metric-learn`` to download and install from PyPI.

+Run ``TO COMPLETE`` to download and install in conda.


We can link to instructions here so it's less verbose in our README? https://github.com/conda-forge/metric-learn-feedstock#installing-metric-learn

Thanks, I have added the simple instructions to install and pointed to this page for more options

terrytangyuan · 2020-03-31T14:20:31Z

README.rst


-Run ``python setup.py install`` for default installation.
+- To install from PyPi: ``pip install metric-learn``.


PyPi -> PyPI

thanks, fixed!

bellet · 2020-03-31T14:31:03Z

Just tested the conda recipe for both Python 2 & 3 and it works well

perimosocordiae · 2020-03-31T16:35:00Z

Thanks again, merged.

bellet · 2020-04-03T07:42:30Z

Note: I also noticed that the PyPi entry is somewhat outdated, for instance the badges for travis and codecov do not work probably due to outdated URL. metric-learn appears in the "My projects" section but the "manage" button is greyed out. Can someone give me the management rights and/or fix the small problems in the PyPi entry? Thanks!

@perimosocordiae @terrytangyuan @wdevazelhes can one of you check this? It looks like at least the CI badge urls need to be updated

terrytangyuan · 2020-04-03T13:50:20Z

@bellet It seems like I cannot update the description manually. The issue is that our last release's README has the outdated URLs. The only solution would be release a new version. Also we need to make sure our README is correct and up-to-date before submitting release to PyPI next time.

bellet · 2020-04-03T13:52:14Z

OK, I did not realize this was directly rendering the README file!

terrytangyuan · 2020-04-03T13:55:35Z

@bellet Just added you as owner on PyPI in case I am away. Hope we'll all be safe around COVID-19 situation. Take care!

bellet · 2020-04-03T13:56:49Z

Thanks!

add placeholder sentence

f3041ec

update setup.cfg to include license file to dist

6195e7d

bellet mentioned this pull request Mar 31, 2020

Add metric_learn conda-forge/staged-recipes#11168

Merged

8 tasks

terrytangyuan reviewed Mar 31, 2020

View reviewed changes

bellet added 3 commits March 31, 2020 16:11

update README

9676706

README

2b3614c

README typo

d3dadbb

terrytangyuan approved these changes Mar 31, 2020

View reviewed changes

terrytangyuan reviewed Mar 31, 2020

View reviewed changes

bellet added 2 commits March 31, 2020 16:24

update doc

46e7deb

typo

1f4a8a0

bellet changed the title ~~Allow installation from conda~~ [MRG] Allow installation from conda Mar 31, 2020

terrytangyuan approved these changes Mar 31, 2020

View reviewed changes

perimosocordiae merged commit 8a02af7 into scikit-learn-contrib:master Mar 31, 2020

bellet deleted the conda-forge branch March 31, 2020 16:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MRG] Allow installation from conda #283

[MRG] Allow installation from conda #283

bellet commented Mar 30, 2020 •

edited

Loading

perimosocordiae commented Mar 30, 2020

terrytangyuan commented Mar 30, 2020

bellet commented Mar 31, 2020

synapticarbors commented Mar 31, 2020

bellet commented Mar 31, 2020

terrytangyuan commented Mar 31, 2020

terrytangyuan Mar 31, 2020

bellet Mar 31, 2020

terrytangyuan Mar 31, 2020

bellet Mar 31, 2020

bellet commented Mar 31, 2020

perimosocordiae commented Mar 31, 2020

bellet commented Apr 3, 2020

terrytangyuan commented Apr 3, 2020

bellet commented Apr 3, 2020

terrytangyuan commented Apr 3, 2020 •

edited

Loading

bellet commented Apr 3, 2020

		@@ -33,6 +33,8 @@ metric-learn contains efficient Python implementations of several popular superv

		Run ``pip install metric-learn`` to download and install from PyPI.

		Run ``TO COMPLETE`` to download and install in conda.


		Run ``python setup.py install`` for default installation.
		- To install from PyPi: ``pip install metric-learn``.

[MRG] Allow installation from conda #283

[MRG] Allow installation from conda #283

Conversation

bellet commented Mar 30, 2020 • edited Loading

perimosocordiae commented Mar 30, 2020

terrytangyuan commented Mar 30, 2020

bellet commented Mar 31, 2020

synapticarbors commented Mar 31, 2020

bellet commented Mar 31, 2020

terrytangyuan commented Mar 31, 2020

terrytangyuan Mar 31, 2020

Choose a reason for hiding this comment

bellet Mar 31, 2020

Choose a reason for hiding this comment

terrytangyuan Mar 31, 2020

Choose a reason for hiding this comment

bellet Mar 31, 2020

Choose a reason for hiding this comment

bellet commented Mar 31, 2020

perimosocordiae commented Mar 31, 2020

bellet commented Apr 3, 2020

terrytangyuan commented Apr 3, 2020

bellet commented Apr 3, 2020

terrytangyuan commented Apr 3, 2020 • edited Loading

bellet commented Apr 3, 2020

bellet commented Mar 30, 2020 •

edited

Loading

terrytangyuan commented Apr 3, 2020 •

edited

Loading