Code

[WIP] New API proposal#85

Code

Closed

wdevazelhes wants to merge 35 commits intoscikit-learn-contrib:masterscikit-learn-contrib/metric-learn:masterfrom

wdevazelhes:new_apiwdevazelhes/metric-learn:new_apiCopy head branch name to clipboard

Commits

Commits on Feb 26, 2018

• Add new class structure

  

  William de Vazelhes

  committed
  3e5fbc3

  Copy full SHA for 3e5fbc3

• Put back TransformerMixin in BaseEstimator to inherit Transformer behaviour even for WeaklySupervisedMetricLearner

  

  William de Vazelhes

  committed
  0cbf1ae

  Copy full SHA for 0cbf1ae

Commits on Feb 27, 2018

• add ConstrainedDataset object

  

  William de Vazelhes

  committed
  300dada

  Copy full SHA for 300dada

Commits on Mar 2, 2018

• simplify constraints to always keep a view on X

  

  William de Vazelhes

  committed
  8615634

  Copy full SHA for 8615634

• add check for input formats

  

  William de Vazelhes

  committed
  a478baa

  Copy full SHA for a478baa

• add basic testing to ConstrainedDataset

  

  William de Vazelhes

  committed
  3744bec

  Copy full SHA for 3744bec

• correct asterisk bug

  

  William de Vazelhes

  committed
  214d991

  Copy full SHA for 214d991

Commits on Mar 5, 2018

• begin work to dissociate classes

  

  William de Vazelhes

  committed
  4f4ce8b

  Copy full SHA for 4f4ce8b

• update MMC with constrained_dataset

  Show description for ac00b8b
  

  William de Vazelhes

  committed
  ac00b8b

  Copy full SHA for ac00b8b

Commits on Mar 6, 2018

• Fixes according to review https://github.com/metric-learn/metric-learn/pull/85#pullrequestreview-101464275

  Show description for 33561ab
  

  William de Vazelhes

  committed
  33561ab

  Copy full SHA for 33561ab

• make mixins rather than classes hierarchy for inheriting special methods

  

  William de Vazelhes

  committed
  7f40c56

  Copy full SHA for 7f40c56

• Merge branch 'new_api' into feat/class_dissociation

  Show description for 402f397
  

  William de Vazelhes

  committed
  402f397

  Copy full SHA for 402f397

Commits on Mar 13, 2018

• Make changes according to review https://github.com/metric-learn/metric-learn/pull/85#pullrequestreview-101963031

  Show description for 47a9372
  

  William de Vazelhes

  committed
  47a9372

  Copy full SHA for 47a9372

Commits on Mar 19, 2018

• Finalize class dissociation into mixins

  Show description for 41dc123
  

  William de Vazelhes

  committed
  41dc123

  Copy full SHA for 41dc123

• Merge branch 'feat/class_dissociation' into new_api

  Show description for 5f63f24
  

  William de Vazelhes

  committed
  5f63f24

  Copy full SHA for 5f63f24

Commits on Mar 20, 2018

• separate valid and invalid input testing

  

  William de Vazelhes

  committed
  fb0d118

  Copy full SHA for fb0d118

• correct too long line syntax

  

  William de Vazelhes

  committed
  df8a340

  Copy full SHA for df8a340

• clarify definition of variables in tests

  

  William de Vazelhes

  committed
  e3e7e0c

  Copy full SHA for e3e7e0c

• simplify unwrap pairs and make it more robust to y dimension

  

  William de Vazelhes

  committed
  5a9c2e5

  Copy full SHA for 5a9c2e5

• fix bug due to bad refactoring of c_shape

  

  William de Vazelhes

  committed
  cf94740

  Copy full SHA for cf94740

• simplify wrap pairs

  

  William de Vazelhes

  committed
  52f4516

  Copy full SHA for 52f4516

Commits on Mar 21, 2018

• make QuadrupletsMixin inherit from WeaklySupervisedMixin

  

  William de Vazelhes

  committed
  079bb13

  Copy full SHA for 079bb13

• add NotImplementedError for abstract mixins

  

  William de Vazelhes

  committed
  da7c8e7

  Copy full SHA for da7c8e7

• put TransformerMixin inline

  

  William de Vazelhes

  committed
  8192d11

  Copy full SHA for 8192d11

• put random state at top of file

  

  William de Vazelhes

  committed
  2d0f1ca

  Copy full SHA for 2d0f1ca

• add transform, predict, decision_function, and scoring for weakly supervised algorithms

  

  William de Vazelhes

  committed
  6c59a1a

  Copy full SHA for 6c59a1a

Commits on Mar 23, 2018

• Add tests

  

  William de Vazelhes

  committed
  b70163a

  Copy full SHA for b70163a

Commits on Mar 30, 2018

• Add documentation

  

  William de Vazelhes

  committed
  a12eb9a

  Copy full SHA for a12eb9a

• fix typo or/of

  

  William de Vazelhes

  committed
  b1f6c23

  Copy full SHA for b1f6c23

Commits on Apr 12, 2018

• Add tests for sparse matrices, dataframes and lists

  Show description for b0ec33b
  

  William de Vazelhes

  committed
  b0ec33b

  Copy full SHA for b0ec33b

• Fix Transformer interface (cf. review https://github.com/metric-learn/metric-learn/pull/85#pullrequestreview-106400253)

  

  William de Vazelhes

  committed
  64f5762

  Copy full SHA for 64f5762

• Do not separate classes if not needed (cf. https://github.com/metric-learn/metric-learn/pull/85#discussion_r175433493)

  

  William de Vazelhes

  committed
  2cf78dd

  Copy full SHA for 2cf78dd

• Fix ascii invisible character

  

  William de Vazelhes

  committed
  11a8ff1

  Copy full SHA for 11a8ff1

• Fix test attribute error and numerical problems with new dataset

  

  William de Vazelhes

  committed
  a768cbf

  Copy full SHA for a768cbf

• Fix unittest hierarchy of classes

  

  William de Vazelhes

  committed
  335d8f4

  Copy full SHA for 335d8f4