Skip to content

Update workflow.md links #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ scikit-learn-contrib is a github organization for gathering high-quality scikit-
* Collaboration: volunteers from around the world can join you in improving the project
* Quality: benefit from scikit-learn's experience in producing high-quality machine learning software
* Transfer: most popular estimators can eventually be promoted to scikit-learn
* URL: http://contrib.scikit-learn.org/project-name
* URL: http://contrib.scikit-learn.org
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be rendered as a link. Put it in backticks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean like this:

* URL: http://contrib.scikit-learn.org

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[http://contrib.scikit-learn.org](http://contrib.scikit-learn.org)


# scikit-learn vs. scikit-learn-contrib

Expand Down Expand Up @@ -41,6 +41,6 @@ that the above requirements are satisfied.
# Project maintenance guidelines

1. Project name on pypi is sklearn-contrib-project-name (e.g., sklearn-contrib-lightning).
2. Upload documentation to your [gh-pages](https://help.github.com/articles/creating-project-pages-manually/) branch.
2. Upload documentation to your [gh-pages](https://help.github.com/en/github/working-with-github-pages/creating-a-github-pages-site) branch.
3. When changing the signature of a public function or class, the old signature must be supported for two releases.
4. The options of all estimators must have sensitible default values.