Skip to content

added __getstate__ method #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 6, 2021
Merged

Conversation

ragrawal
Copy link
Collaborator

closes #224

@ragrawal ragrawal marked this pull request as draft November 22, 2020 08:37
@ragrawal ragrawal requested a review from dukebody November 22, 2020 08:37
@ragrawal ragrawal self-assigned this Nov 22, 2020
@ragrawal ragrawal marked this pull request as ready for review November 22, 2020 08:37
@ragrawal ragrawal marked this pull request as draft November 22, 2020 08:38
@ragrawal
Copy link
Collaborator Author

Baikal uses an adapter pattern where it dynamically extends the functionality of classes. However, it's make_step method fails because sklearn_pandas has setstate_ method but not getstate method. Also from consistency perspective it make sense to have both these methods implemented. One option is to get rid of setstate method but that will break backward compatibility.
@dukebody -- I would love to get your perspective on this.

@ragrawal ragrawal marked this pull request as ready for review November 22, 2020 23:55
@ragrawal ragrawal merged commit 46611ca into scikit-learn-contrib:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement __getstate__
1 participant