-
Notifications
You must be signed in to change notification settings - Fork 60
switch from Travis to GH actions #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Gallaecio @ejulio switched from Travis to GH actions, tests passing for 3.6 until 3.9. Having working CI is an essential condition for doing any other work, e.g. on porting to 3.10. Cassettes are working fine in 3.9 but failing in Python 3.10. Need to investigate why tests are failing with cassettes via vcrpy https://github.com/kevin1024/vcrpy there seems to be something with this library. Latest release of vcrpy was in October 2020, I'm not sure how active project is, perhaps we should switch to different library providing similar functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @pawelmhm, thanks.
Can we keep tox.ini
just like we have for other projects? (scrapy, parsel, itemadapter come to mind). That way we can handle the msgpack tests (and other checks like flake8/black/pylint) more easily IMHO.
Lastly, it would be good to have a workflow to publish the package to PyPI. I get that the Travis build is not currently working anyway, so I don't think that should be a blocker for this PR.
thanks for review @elacuesta I'll include your feedback in next commit |
2e8cb28
to
40cec82
Compare
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 93.96% 94.27% +0.31%
==========================================
Files 28 28
Lines 1938 1958 +20
==========================================
+ Hits 1821 1846 +25
+ Misses 117 112 -5
Continue to review full report at Codecov.
|
|
About PYPI_TOKEN I don't have permissions to create one so we need to wait for @Gallaecio, would be also nice to have token to testpypi to test it first on first release via github. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, many thanks @pawelmhm. The PyPI token was added to the repo secrets some time ago by @Gallaecio, we don't need to worry about it.
No description provided.