Feat: Fix distributed sampler for multi GPU #3053
Open
+215
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…o Ori-Distributed-Sampler-Fix
for more information, see https://pre-commit.ci
…o Ori-Distributed-Sampler-Fix # Conflicts: # tests/dataloaders/test_dataloaders.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3053 +/- ##
==========================================
- Coverage 84.60% 84.59% -0.01%
==========================================
Files 178 178
Lines 15052 15056 +4
==========================================
+ Hits 12734 12737 +3
- Misses 2318 2319 +1
|
…atches between gpus
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…o Ori-Distributed-Sampler-Fix
for more information, see https://pre-commit.ci
|
CUDA-distributed tests work locally, but not from the runner, we need to make it work |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for the dataloader in case of distributed sampler
close #3047