Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gimVI mini batch append on CPU first #3058

Merged
merged 3 commits into from
Nov 29, 2024
Merged

fix: gimVI mini batch append on CPU first #3058

merged 3 commits into from
Nov 29, 2024

Conversation

ori-kron-wis
Copy link
Collaborator

Fixing gimVI get_latent and get_imputed to append mini batches into CPU first (and not to GPU first) in order to save GPU memory, as was done in VAE.

close #3057

@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Nov 28, 2024
@ori-kron-wis ori-kron-wis added this to the scvi-tools 1.2 milestone Nov 28, 2024
@ori-kron-wis ori-kron-wis self-assigned this Nov 28, 2024
@ori-kron-wis ori-kron-wis mentioned this pull request Nov 28, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.53%. Comparing base (bcd7e67) to head (57d022c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3058   +/-   ##
=======================================
  Coverage   84.53%   84.53%           
=======================================
  Files         178      178           
  Lines       15067    15067           
=======================================
  Hits        12737    12737           
  Misses       2330     2330
Files with missing lines Coverage Δ
src/scvi/external/gimvi/_model.py 91.70% <100.00%> (ø)

@canergen canergen merged commit e4f4bac into main Nov 29, 2024
12 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Nov 29, 2024
@ori-kron-wis @meeseeksmachine
Backport PR scverse#3058: fix: gimVI mini batch append on CPU first
a8695b5
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 29, 2024
Merged
canergen pushed a commit that referenced this pull request Nov 29, 2024
@meeseeksmachine @ori-kron-wis
Backport PR #3058 on branch 1.2.x (fix: gimVI mini batch append on CP…
883a5e6 
…U first) (#3059)

Backport PR #3058: fix: gimVI mini batch append on CPU first

Co-authored-by: Ori Kronfeld <ori.kronfeld@weizmann.ac.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canergen canergen Awaiting requested review from canergen

Assignees

@ori-kron-wis ori-kron-wis

Labels
on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Milestone
scvi-tools 1.2
Development

Successfully merging this pull request may close these issues.

gimVI - multi-GPU support?
2 participants
@ori-kron-wis @canergen