Snippet refactor for #9 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works better, I guess the dependency (vetur) made a change that causes this issue in the snippets since it was clearly working at one point. I would suggest one more "", in the vbase snippet... to add a newline after the closing <style> tag. That makes the stricter ESLint (rule eol-last) happy that the file ends with a newline. |
|
Thanks for the PR, it's too bad vetur is causing this issue, but I should be able to take a look sometime after this weekend. |
|
Finally had a day off from speaking! Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry somehow this slipped off my todo-list 😅
Changes:
vuesnippet only hasvbase, which is available outside<template>,<script>and<style>vue-template.jsonare available for both Vue files (only in<template>section) and html files.vue-script.jsonandvue-script-vuex.jsonare availble for both Vue files (only in<script>section) and js files.vincandvdecseems to be for js instead of plaintext, so I moved them to the correct place in Readme.