feat: Prevent overriding the value from config (GoogleCloudPlatform#7218)

irvifa · web-flow · commit db182f77a0d2 · 2021-12-25T09:02:28.000Z
## Description Fixes #<ISSUE-NUMBER>Previously the DEBUG env var will always be overridden into True, while we already have a way to read it from env var. By setting the default value as True and not overridding the value later we can retainthe DEBUG value provided from the users. Note: It's a good idea to open an issue first for discussion. ## Checklist - [x] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md) - [x] **Tests** pass: `nox -s py-3.6` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup)) - [x] **Lint** pass: `nox -s lint` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup)) - [x] Please **merge** this PR for me once it is approved.
diff --git a/run/django/mysite/settings.py b/run/django/mysite/settings.py
@@ -22,7 +22,9 @@
 BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
 
 # [START cloudrun_django_secret_config]
-env = environ.Env(DEBUG=(bool, False))
+# SECURITY WARNING: don't run with debug turned on in production!
+# Change this to "False" when you are ready for production
+env = environ.Env(DEBUG=(bool, True))
 env_file = os.path.join(BASE_DIR, ".env")
 
 # Attempt to load the Project ID into the environment, safely failing on error.
@@ -61,9 +63,7 @@
 # [END cloudrun_django_secret_config]
 SECRET_KEY = env("SECRET_KEY")
 
-# SECURITY WARNING: don't run with debug turned on in production!
-# Change this to "False" when you are ready for production
-DEBUG = True
+DEBUG = env("DEBUG")
 
 # SECURITY WARNING: It's recommended that you change this setting when
 # running in production. The URL will be known once you first deploy
