This repository was archived by the owner on Feb 13, 2024. It is now read-only.
refactor: move cli to a sub-package #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1cba28 to
f00582a
Compare
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 108 108
=====================================
Hits 108 108Continue to review full report at Codecov.
|
f2prateek
reviewed
Oct 12, 2018
cli/package.json
Outdated
| "segment" | ||
| ], | ||
| "dependencies": { | ||
| "analytics-node": "^3.3.0" |
There was a problem hiding this comment.
Can we make this depend the local version? Otherwise our end to end tests will be testing an outdated version
It adds unnecessary bulk to `analytics-node`, and will be moved to it's own package.
f00582a to
0bd2241
Compare
f2prateek
approved these changes
Oct 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current npm package bundles a CLI, which adds some unnecessary bloat to the package size. This PR removes this bloat, and will be moved to a separate repo/package.