Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

Upgrade devDependencies #212

Merged
merged 3 commits into from
Jun 7, 2019
Merged

Upgrade devDependencies #212

merged 3 commits into from
Jun 7, 2019

Conversation

fathyb
Copy link
Contributor

@fathyb fathyb commented Jun 5, 2019 •
edited
Loading

Snyk alert: https://app.snyk.io/org/segment-pro/project/cf7257d6-cfcf-49ce-a652-81ce8bdbca59#issue-SNYK-JS-HANDLEBARS-174183

Version check:

➜  analytics-node git:(dev-deps/update) yarn why handlebars
yarn why v1.16.0
[1/4] 🤔  Why do we have the module "handlebars"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "handlebars@4.1.2"
info Reasons this module exists
   - "nyc#istanbul-reports" depends on it
   - Hoisted from "nyc#istanbul-reports#handlebars"
info Disk size without dependencies: "2.7MB"
info Disk size with unique dependencies: "4.56MB"
info Disk size with transitive dependencies: "4.72MB"
info Number of shared dependencies: 5
✨  Done in 0.67s.

I changed the node 6 test env to 12, as 6 reached EOL and 12 is the current stable https://github.com/nodejs/Release

Ref: https://segment.atlassian.net/browse/LIB-1016

@fathyb fathyb requested a review from f2prateek June 5, 2019 09:59
@fathyb fathyb changed the title Dev deps/update Upgrade devDependencies Jun 5, 2019
@swaters-atlassian swaters-atlassian mentioned this pull request Jun 5, 2019
Merged
@fathyb fathyb merged commit eefaf83 into master Jun 7, 2019
@fathyb fathyb deleted the dev-deps/update branch June 7, 2019 16:23
@LukeAskew
Copy link

Any update on when this will be released?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@f2prateek f2prateek f2prateek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fathyb @LukeAskew @f2prateek