This repository was archived by the owner on Feb 13, 2024. It is now read-only.
Feature: Allow passing axios instance or config in options. #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbassut
reviewed
Jan 11, 2021
| * @property {Number} [flushAt] (default: 20) | ||
| * @property {Number} [flushInterval] (default: 10000) | ||
| * @property {String} [host] (default: 'https://api.segment.io') | ||
| * @property {Boolean} [enable] (default: true) |
Closed
pooyaj
approved these changes
Feb 11, 2021
|
@krisdages @pbassut could you please fix the conflict so we can merge this? |
|
Sure. Notice we don't need to merge #246 if we merge this. |
|
Also, I'll have to create another PR to fix the conflicts here. |
|
@pbassut oh, sorry just merged the other one. Agree, this would've covered that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
I have an Electron app using axios for HTTP where I am using a custom adapter to get around proxy issues by using Electron's
netmodule.My workaround:
The current version of
analytics-nodedoesn't expose any configuration foraxios, so I added the followingoptionsproperties:axiosConfig: configuration options for creating an axios instance if you don't have axios as a dependencyaxiosInstance: instance of axios if you already have axios as a dependency, maybe with a different versionIt's not ideal from a library-coupling perspective, but I didn't see an easy way to avoid that without
defining some library-agnostic interface for the HTTP adapter which would still support retries, which seems overkill.
I just thought I would post this PR in case it was a useful enhancement.
Alternative considered:
One option
axioswith either a config object or a function returning an axios instance.