This repository was archived by the owner on Feb 13, 2024. It is now read-only.
upgrade uuid dep to support bundler tree shaking #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/uuidjs/uuid/blob/master/README_js.md#deep-requires-now-deprecated From the above document, the motivation for upgrading: As of uuid@7.x this library now provides ECMAScript modules builds, which allow packagers like Webpack and Rollup to do "tree-shaking" to remove dead code.
|
I'm not sure how to get the "ci/circleci: synk" check to run. Do I need an account or could somebody on the segmentio side help make sure it passes? |
pooyaj
approved these changes
Mar 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/uuidjs/uuid/blob/master/README_js.md#deep-requires-now-deprecated
From the above document, the motivation for upgrading:
As of uuid@7.x this library now provides ECMAScript modules builds,
which allow packagers like Webpack and Rollup to do "tree-shaking" to
remove dead code.