Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

flushing when payload max size has reached #277

Merged
merged 9 commits into from
Jun 23, 2021
Merged

flushing when payload max size has reached #277

merged 9 commits into from
Jun 23, 2021

Conversation

pbassut
Copy link
Contributor

@pbassut pbassut commented Apr 25, 2021 •
edited
Loading

Closes #276 #219

pooyaj
pooyaj reviewed May 19, 2021
View reviewed changes
pooyaj
pooyaj reviewed May 31, 2021
View reviewed changes
Copy link
Contributor

@pooyaj pooyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbassut looks like one of the tests are failing 🤔 can you please check that before we merge it?

@pbassut
Copy link
Contributor Author

pbassut commented Jun 23, 2021

I had to remove support for node 8 since one of our libraries dropped support for it already.
If this is a concern, maybe we should rethink how we're going to do http requests with another library.

@nd4p90x nd4p90x linked an issue Jun 23, 2021 that may be closed by this pull request
Flush Race Condition #219
Closed
pooyaj
pooyaj approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@pooyaj pooyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop Node 8 support as it is already EOL-ed for a while.

@pooyaj pooyaj merged commit aeda99e into segmentio:master Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pooyaj pooyaj pooyaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flush when maximum storage size limit has been reached Flush Race Condition
3 participants
@pbassut @pooyaj @nd4p90x