[STRATCONN-5687] Added support for bing ads consent mode #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs.js-integrations into bing-ads-consent
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Bing Ads consent mode by updating the configuration for webpack builds and implementing consent handling in the Bing Ads integration.
- Updates webpack configuration files to use SHA-256 for hashing.
- Implements consent initialization and dynamic consent updates in the Bing Ads integration.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| webpack.config.tester.js | Adds hashFunction with SHA-256 to the output configuration. |
| webpack.config.middleware.js | Adds hashFunction with SHA-256 to the middleware build configuration. |
| webpack.config.integrations.js | Adds hashFunction with SHA-256 to the integrations build configuration. |
| integrations/bing-ads/lib/index.js | Implements Bing Ads consent mode logic in both initialize and track methods. |
Files not reviewed (1)
- integrations/bing-ads/package.json: Language not supported
Comment on lines
+34
to
+36
| var consent = { | ||
| ad_storage: self.options.adStorage || 'denied' | ||
| }; |
There was a problem hiding this comment.
[nitpick] The consent object creation logic appears in both the initialize and track methods; consider refactoring this repeated logic into a helper function to improve maintainability.
Suggested change
| var consent = { | |
| ad_storage: self.options.adStorage || 'denied' | |
| }; | |
| var consent = self.createConsentObject({ adStorage: self.options.adStorage }); |
Copilot uses AI. Check for mistakes.
varadarajan-tw
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR added support for bing ads consent mode changes.
JIRA TICKETS: https://twilio-engineering.atlassian.net/browse/STRATCONN-5687
Are there breaking changes in this PR?
NO
Testing
Testing completed successfully
When Default is granted
When default is denied and Manual value mapped when CMP is not used
when default is denied and is a CMP user.
Any background context you want to provide?
Is there parity with the server-side/android/iOS integration components (if applicable)?
Does this require a new integration setting? If so, please explain how the new setting works
Links to helpful docs and other external resources