Skip to content

fix(): Add missing link and add padding #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2019
Merged

fix(): Add missing link and add padding #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63089da
fix(): Add missing link and add padding
bart-tonik Oct 11, 2019
3ae12d9
fix(): Change dedicated link field to markdownify content
bart-tonik Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/_includes/components/faq.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ <h3>{{ item[0] }}</h3>
{% include icons/symbols/chevron-down.svg %}
</div>
</div>
<div class="accordion__body" data-ref="accordion[body]">{{ itemEl.content }}</div>
<div class="accordion__body" data-ref="accordion[body]">
{{ itemEl.content | markdownify }}
</div>
</div>
{% endfor %}
</div>
Expand Down
11 changes: 11 additions & 0 deletions src/_sass/components/_accordion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,17 @@
&__body {
display: none;
padding-bottom: 20px;

@include breakpoint(medium up) {
padding-right: 45px;
}

a {
text-decoration: underline;
font-weight: 500;
display: block;
margin-top: 7px;
}
}

&__icon {
Expand Down
3 changes: 2 additions & 1 deletion src/styleguide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ layout: page
faq:
Source:
- title : "Should I track client or server-side?"
content : "One of the most common questions we receive is: “Should I use one of your client-side libraries or one of your server-side libraries?” This is such an important topic that we’ve written up an in-depth article in our Analytics Academy: When to Track on the Client vs Server. It’s worth a read!"
content : "One of the most common questions we receive is: “Should I use one of your client-side libraries or one of your server-side libraries?” This is such an important topic that we’ve written up an in-depth article in our Analytics Academy: When to Track on the Client vs Server. It’s worth a read!
[Read more](#)"
- title : "What are best practices in identifying users?"
content : "One of the most common questions we receive is: “Should I use one of your client-side libraries or one of your server-side libraries?” This is such an important topic that we’ve written up an in-depth article in our Analytics Academy: When to Track on the Client vs Server. It’s worth a read!"
Cloud Sources:
Expand Down