Skip to content

fix(): Missing mobile nav for integration page #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2019
Merged

fix(): Missing mobile nav for integration page #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/_layouts/integration.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,20 @@ <h1 id="{{ page.title | downcase }}" class="page__heading">
{{ page.title }}
</h1>
{%- endif -%}

{%- if page.excerpt -%}
<div class="integration-header__content">
{{ page.excerpt | markdownify }}
</div>
{%- endif -%}
</div>
</div>

<hr>

{%- unless page.hide_toc -%}
{% include sidebar/mobile-menu-side.html %}
{%- endunless -%}

<div class="integration__body markdown">
{{ content }}
Expand Down
17 changes: 3 additions & 14 deletions src/_sass/pages/_integration.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,10 @@
}

&__body {
margin-top: 70px;
margin-top: 30px;

& > h2 {
margin-top: 70px;
position: relative;

&::after {
height: 1px;
width: 100%;
position: absolute;
top: -35px;
left: 0;
background-color: rgba(color(secondary), 0.16);
content: "";
}
@include breakpoint(large up) {
margin-top: 50px;
}
}
}
16 changes: 15 additions & 1 deletion src/connections/destinations/catalog/optimizely-web/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ If you’re interested in implementing Optimizely Full Stack server-side or on m
* [Use Optimizely to A/B test which CTAs lead to more signups](https://segment.com/recipes/ab-test-cta-signups-optimizely/)
* [Test which call to action (CTA) results in more shopping cart conversions with Optimizely](https://segment.com/recipes/ab-test-cta-conversions-optimizely/)

---

## Implementation Prerequisite

Optimizely works differently than other Segment destinations: It requires that customers implement at least some Optimizely functionalities natively.
Expand All @@ -35,6 +37,8 @@ This limitation requires that customers include a native Optimizely snippet or i

Segment provides specific implementation details for each Optimizely product in the sections below, in addition to details of the out-of-the-box mappings Segment's Optimizely component handles for Optimizely users.

---

## Optimizely Classic Web

### Getting Started
Expand Down Expand Up @@ -161,6 +165,8 @@ analytics.identify({

If you run multiple experiments during a user session, since `traits` are cached, subsequent experiments would fire `identify` calls that contain previous experiment data.

---

## Optimizely Classic Android

{% capture noteAndroid %}
Expand Down Expand Up @@ -210,6 +216,8 @@ Upon an Optimizely experiment activation, Segment’s Optimizely Classic<>Androi
.putValue("variationName", optimizelyExperimentData.variationName));
```

---

## Optimizely Classic iOS

{% capture noteIOS %}
Expand All @@ -227,7 +235,7 @@ For Segment’s Optimizely Full Stack iOS destination, see Segment's [Optimizely
{% include components/list-steps.html number="5" content="Instantiate Segment’s global Analytics object with an Optimizely factory registered:" %}

```objc
[config use:[SEGOptimizelyIntegrationFactory instanceWithToken: /* your Optimizely project id /* launchOptions:launchOptions]];
[config use:[SEGOptimizelyIntegrationFactory instanceWithToken: /* your Optimizely project id */ launchOptions:launchOptions]];
```

Since Optimizely needs to be initialized as early as possible, you need to supply the Optimizely `projectId` when you initialize the factory registered with the analytics client. Once registered, Segment maps `track` and `identify` to Optimizely.
Expand Down Expand Up @@ -263,6 +271,8 @@ Upon an Optimizely experiment activation, Segment’s Optimizely Classic<>iOS SD
}];
```

---

## Optimizely X Web

### Getting Started
Expand Down Expand Up @@ -363,6 +373,8 @@ If you’re sending your experiments to Google Analytics in the form of `track`

![](images/customdimensions.png)

---

## Optimizely Full Stack (JavaScript)

### Getting Started
Expand Down Expand Up @@ -407,6 +419,8 @@ If you are sending anonymous data to Optimizely X Full Stack via their server-si
});
```

---

## Troubleshooting

### No Data for Anonymous Users
Expand Down