Skip to content

fix(): Change line-eight of heading, align symbol to right #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2019
Merged

fix(): Change line-eight of heading, align symbol to right #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@
<div class="page-404">
<div class="flex">
<div class="flex__column--12 flex__column--9@xlarge">
<h1>The page you were looking for doesn’t exist.</h1>
<h1 class="page-404__heading">The page you were looking for doesn’t exist.</h1>
<div class="flex">
<div class="flex__column--10 markdown">
<div class="flex__column--12 flex__column--10@xlarge markdown">
<p>You may have mistyped the address or the page may have moved. Double-check the URL and try again or search the term.</p>

<div class="search" data-search>
{% include navbar/search.html placeholder="Enter a search term" %}
<div class="search search--mobile" data-search>
{% include navbar/search.html placeholder="Enter a search term" mobile="true" %}
</div>
</div>
</div>
Expand Down
12 changes: 7 additions & 5 deletions src/_includes/navbar/search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@

<input class="field__input input DocsNav-search-input" type="text" placeholder="{{ include.placeholder }}"/>

<div class="field__icon field__icon--right flex flex--middle flex--center">
<button class="field__button" data-ref="search-navbar[trigger]">
{% include icons/symbols/close.svg %}
</button>
</div>
{% unless include.mobile %}
<div class="field__icon field__icon--right flex flex--middle flex--center">
<button class="field__button" data-ref="search-navbar[trigger]">
{% include icons/symbols/close.svg %}
</button>
</div>
{% endunless %}
</div>
4 changes: 4 additions & 0 deletions src/_sass/components/_search.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,8 @@
@include breakpoint(large up) {
display: block;
}

&--mobile {
display: block;
}
}
1 change: 1 addition & 0 deletions src/_sass/components/_stage.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
&__content {
padding-left: 20px;
padding-right: 20px;
position: relative;

@include breakpoint(large up) {
padding-left: 0;
Expand Down
14 changes: 13 additions & 1 deletion src/_sass/pages/_page-404.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
margin-top: 90px;
}

&__heading {
line-height: 56px;

& + * {
margin-top: 10px;
}
}

&__numeric-heading {
color: rgba(color(gray), 0.1);
font-size: 195px;
Expand All @@ -11,8 +19,12 @@

&__numeric-heading__wrapper {
display: none;
position: absolute;
right: 0;
top: 50%;
transform: translateY(-50%);

@include breakpoint(large up) {
@include breakpoint(xlarge up) {
display: flex;
}
}
Expand Down