Skip to content

Release 21.43.2 #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/unallowed-contributions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ on:

jobs:
triage:
if: github.repository == 'segmentio/segment-docs' && (github.event.pull_request.user.login != 'markzegarelli' || github.event.pull_request.user.login != 'stayseesong' || github.event.pull_request.user.login != 'pwseg')
if: github.repository == 'segmentio/segment-docs' && github.event.pull_request.user.login != 'markzegarelli' || github.event.pull_request.user.login != 'stayseesong' || github.event.pull_request.user.login != 'pwseg'
runs-on: ubuntu-latest
steps:
- name: Get files changed
Expand Down Expand Up @@ -93,4 +93,4 @@ jobs:
console.log("Error creating comment.", err)
}

core.setFailed(workflowFailMessage)
core.setFailed(workflowFailMessage)
2 changes: 1 addition & 1 deletion src/config-api/tutorial-javascript-google-analytics.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ To set up Segment Protocols through the API you first need to create a personal

1. Log in to your Segment workspace.
2. Click **Settings** in the left navigation bar.
3. Click **Access Management**, then the **Tokens** tab, and click **Create Token**.
3. Go to **Settings > Workspace Settings > Access Management**. Select the **Tokens** tab, and click **Create Token**.
4. For purposes of this demonstration, select **Workspace Owner** as the token's scope.
5. Enter a description for the token. For this demo, we recommend using `demo-token` so it's easy to find and remove later.
6. Click **Create**.
Expand Down
4 changes: 2 additions & 2 deletions src/connections/destinations/catalog/eloqua/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ the Segment `group` event needs to include the Account's name and groupId. If
you set up a custom Account field called Company in Eloqua, Segment will
automatically map the name of the Account to that field.

Follow the Segment spec to ensure proper mapping of these fields from Segment
`group` traits: https://segment.com/docs/connections/spec/group/#traits.
Follow [Segment's group spec](https://segment.com/docs/connections/spec/group/#traits) to ensure proper mapping of these fields from Segment
`group` traits.

In addition, Segment supports mapping custom `group` traits to Eloqua custom
object fields. To do so, you can set up mappings in the settings for your
Expand Down
Loading