-
Notifications
You must be signed in to change notification settings - Fork 362
Add five new Zendesk collections [DOC-452] #2632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… the table to each collection
✅ Deploy Preview for segment-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
</tr> | ||
<tr> | ||
<td>id</td> | ||
<td>Automatically assigned when creating groups. </td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td>Automatically assigned when creating groups. </td> | |
<td>This is automatically assigned when creating groups. </td> |
</tr> | ||
<tr> | ||
<td>id</td> | ||
<td> Automatically assigned when creating groups. </td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td> Automatically assigned when creating groups. </td> | |
<td> This is automatically assigned when creating groups. </td> |
</tr> | ||
<tr> | ||
<td>updated_at</td> | ||
<td>When this record was last updated.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td>When this record was last updated.</td> | |
<td>The time this record was last updated.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this is supposed to be date or time?
</tr> | ||
<tr> | ||
<td>created_at</td> | ||
<td>When this record was created.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td>When this record was created.</td> | |
<td>The time this record was created.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is supposed to be date or time. I just put time but should change to date if it's date
<tr> | ||
<th>Property</th> | ||
<th>Description</th> | ||
</tr> | ||
<tr> | ||
<td>id</td> | ||
<td> Automatically assigned when creating groups. </td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td> Automatically assigned when creating groups. </td> | |
<td> This automatically assigns when creating groups. </td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Automatically assigned when creating groups.
This automatically assigns when creating groups.
Would it be clearer to say "This is automatically assigned when groups are created" or something similar?
<tr> | ||
<th>Property</th> | ||
<th>Description</th> | ||
</tr> | ||
<tr> | ||
<td>id</td> | ||
<td> Automatically assigned when the user is created. </td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td> Automatically assigned when the user is created. </td> | |
<td> This automatically assigns when the user is created. </td> |
<tr> | ||
<th>Property</th> | ||
<th>Description</th> | ||
</tr> | ||
<tr> | ||
<td>id</td> | ||
<td> Automatically assigned when the ticket is created.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td> Automatically assigned when the ticket is created.</td> | |
<td> This automatically assigns when you create a ticket.</td> |
<tr> | ||
<th>Property</th> | ||
<th>Description</th> | ||
</tr> | ||
<tr> | ||
<td>id</td> | ||
<td> Automatically assigned upon creation.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td> Automatically assigned upon creation.</td> | |
<td> This automatically assigns upon creation.</td> |
@@ -507,6 +539,7 @@ In your warehouse, each collection gets its own table. Find below a list of the | |||
<td>updated_at</td> | |||
<td> When this record last got updated.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td> When this record last got updated.</td> | |
<td> The time this record last got updated.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this time or date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Zendesk docs don't specify if it's a date, time, or both. I'll ask an engineer to see what this property entails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a date and time, I'll update accordingly.
@@ -507,6 +539,7 @@ In your warehouse, each collection gets its own table. Find below a list of the | |||
<td>updated_at</td> | |||
<td> When this record last got updated.</td> | |||
</tr> | |||
<tr> | |||
<td>assignee_updated_at</td> | |||
<td> When the assignee last updated the ticket.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td> When the assignee last updated the ticket.</td> | |
<td> The time the assignee last updated the ticket.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this time or date?
@@ -523,10 +556,11 @@ In your warehouse, each collection gets its own table. Find below a list of the | |||
<td> When the ticket was initially assigned.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td> When the ticket was initially assigned.</td> | |
<td> The time the ticket was initially assigned.</td> |
@@ -523,10 +556,11 @@ In your warehouse, each collection gets its own table. Find below a list of the | |||
<td> When the ticket was initially assigned.</td> | |||
</tr> | |||
<tr> | |||
<td>assigned_at</td> | |||
<td>assigned_at</td> | |||
<td> When the ticket was last assigned.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td> When the ticket was last assigned.</td> | |
<td> The time the ticket was last assigned.</td> |
<td> When the ticket was last assigned.</td> | ||
</tr> | ||
<td>solved_at</td> | ||
<tr> | ||
<td>solved_at</td> | ||
<td> When the ticket was solved.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td> When the ticket was solved.</td> | |
<td> The time the ticket was solved.</td> |
@forstisabella if you have time, I would actually change the formatting of the collections tables to have this formatting instead of using the table tags
|
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
Added five new Zendesk collections and their properties, modified existing content to adhere to Vale rules, removed property with no description in
ticket_events
collection (as okayed by Sarthak G.,) linked collections in overview table to their accompanying table of properties.Merge timing
On March 31, when the Zendesk collections are released!
Related issues (optional)
DOC-452