Niall/kinesis base64 remove #2640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2022 09:49
markzegarelli
approved these changes
Mar 23, 2022
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
markzegarelli
pushed a commit
that referenced
this pull request
Mar 24, 2022
* Niall/kinesis base64 remove (#2640) * remove base 64 docs * remove base 64 docs Co-authored-by: Niall Brennan <niall.brennan@segment.com> * these are not partner owned * REST vs. SOAP endpoint I made a mistake when setting up Marketo. Putting this line in in the hopes of preventing other users from making the same mistake. * Catalog updates for new integrations (#2650) * Swift/Kotlin no longer in beta (#2649) * no longer in beta * no longer in beta Co-authored-by: Niall Brennan <niall.brennan@segment.com> * Prevent mistakes when setting up Marketo (#2646) Make docs easier to follow. - Correct minor misspellings between our docs and Marketo's interface - Add a callout to check the API Only box - Make it clear that the audience takes a few hours to sync. * Add Groundswell Destination to Segment Doc (#2644) * Groundswell doc * catalog and edits Co-authored-by: Sneha Shashidhar <sneha.shashidhar@segment.com> Co-authored-by: markzegarelli <mark.zegarelli@segment.com> Co-authored-by: Segment Docs Robot <73141528+bot-docsteam@users.noreply.github.com> Co-authored-by: Niall Brennan <niallbrennan87@gmail.com> Co-authored-by: Niall Brennan <niall.brennan@segment.com> Co-authored-by: gyeuttersegment <93450145+gyeuttersegment@users.noreply.github.com> Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com> Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> Co-authored-by: Sneha Shashidhar <97519099+sneha-shashidhar@users.noreply.github.com> Co-authored-by: Sneha Shashidhar <sneha.shashidhar@segment.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
A customer wrote in about the base 64 encoding, and observed the payloads were not base 64 encoded. Checking out the code I do not see nay logic around base 64 encoding, and our code in the docs was also incorrect.
https://github.com/segmentio/integrations/blob/master/integrations/amazon-kinesis/lib/index.js#L96
Removing references to base 64 encoding.