Correcting Page methods name #2676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
‘destinations.methods.page_view’ should be ‘destinations.methods.page’ to match the naming convention found in destinations.yml
pwseg
approved these changes
Mar 31, 2022
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
‘destinations.methods.page_view’ should be ‘destinations.methods.page’ to match the naming convention found in destinations.yml
Proposed changes
The methods compare page (https://segment.com/docs/connections/destinations/methods-compare/) was not showing any Page calls. Believe this is due to bad naming conventions, which I tried to fix in these edits.
Merge timing
ASAP after approval
Related issues (optional)
#2669