Skip to content

Updated Retry Policy FAQ #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2022
Merged

Updated Retry Policy FAQ #2690

merged 2 commits into from
Apr 1, 2022

Conversation

gsikri
Copy link
Contributor

@gsikri gsikri commented Apr 1, 2022

Proposed changes

Previously, In the Source Functions FAQs -> Retry Policy it was mentioned that message is retried 5 times which is not correct. We retry a message for 6 times before dropping it.

Reference

Merge timing

  • ASAP once approved.

@gsikri
Updated Retry Policy FAQ
b9058fd 
Previously, In the Source Functions FAQs -> Retry Policy it was mentioned that message is retried 5 times which is not correct. We actually retry a message for 6 times before dropping it.

Reference: https://github.com/segmentio/terracode-infra/blob/master/production/us-west-2/core/functions/kubeapply.tf#L75
@gsikri gsikri requested a review from a team as a code owner April 1, 2022 11:14
@gsikri gsikri requested review from stayseesong and forstisabella and removed request for a team April 1, 2022 11:14
forstisabella
forstisabella approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending small stylistic changes!

@stayseesong stayseesong added the fixed-content fix to content that has outdated or wrong information label Apr 1, 2022
@stayseesong stayseesong merged commit 0e03cb7 into develop Apr 1, 2022
@stayseesong stayseesong deleted the patch/gsikri/source-functions-faqs-retryPolicy branch April 1, 2022 23:51
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayseesong stayseesong stayseesong approved these changes

@forstisabella forstisabella forstisabella approved these changes

Assignees
No one assigned
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsikri @stayseesong @forstisabella