Skip to content

Updated Google Ads docs after API upgrade [DOC-458] #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 21, 2022
Merged

Conversation

forstisabella
Copy link
Contributor

Proposed changes

Made changes to the Google Ads source as requested by PM/engineering:

  • Updated external links from Adwords to Google Ads
  • Indicated deprecated fields
  • Added notes to properties with changed functionality
  • Added note that Include Zero Impressions is no longer supported

Merge timing

April 20th (or earlier: I have approval to publish docs before the API changes are GA)

Related issues (optional)

N/A

@forstisabella forstisabella requested a review from a team as a code owner April 8, 2022 16:21
@forstisabella forstisabella requested review from rchinn1 and removed request for a team April 8, 2022 16:21
@netlify
Copy link

netlify bot commented Apr 8, 2022

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit f0c1801
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/6255d972bfa1380009e6a0e2
😎 Deploy Preview https://deploy-preview-2728--segment-docs.netlify.app/connections/sources/catalog/cloud-apps/google-ads
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@rchinn1 rchinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left a few minor suggestions.

@forstisabella forstisabella merged commit 343c841 into develop Apr 21, 2022
@forstisabella forstisabella deleted the DOC-458-IF branch April 21, 2022 12:26
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants