Skip to content

Update to install image, AJS 2.0 and help email #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 21, 2022
Merged

Update to install image, AJS 2.0 and help email #2776

merged 7 commits into from
Apr 21, 2022

Conversation

edwardupton
Copy link
Contributor

Proposed changes

Changes for clarity and new feature supporting AJS 2.0

@edwardupton edwardupton requested a review from a team as a code owner April 21, 2022 14:01
@edwardupton edwardupton requested a review from rchinn1 April 21, 2022 14:01
rchinn1
rchinn1 requested changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@rchinn1 rchinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @edwardupton. Just a few requested changes.

@rchinn1 rchinn1 added the fixed-content fix to content that has outdated or wrong information label Apr 21, 2022
@rchinn1 rchinn1 changed the base branch from master to develop April 21, 2022 16:32
edwardupton and others added 4 commits April 21, 2022 17:57
@edwardupton @rchinn1
Period
a56c132 
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
@edwardupton @rchinn1
Target blank
81992cf 
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
@edwardupton @rchinn1
isn't
2285362 
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
@edwardupton @rchinn1
example
afa76c5 
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
@edwardupton
Copy link
Contributor Author

@rchinn-segment all resolved

@rchinn1 rchinn1 merged commit e77f633 into segmentio:develop Apr 21, 2022
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchinn1 rchinn1 rchinn1 approved these changes

Assignees
No one assigned
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardupton @rchinn1