Config API fixes #282
Merged
Config API fixes #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzoschke
approved these changes
Nov 21, 2019
| menu_icon: new-tab | ||
| - path: /config-api/fql | ||
| title: Destination Filter Query Language | ||
| - path: "https://reference.segmentapis.com/" |
There was a problem hiding this comment.
Is there a different key for for an external link?
One https://segment.build/docs/config-api/destination-filters/fql/, this Reference link is broken and sends you to
https://app.segment.build/docshttps:/reference.segmentapis.com/
There was a problem hiding this comment.
Hmm, that's not good. I'm going to have to file a bug for that.
|
I'm going to merge this for now and we can put in a page back and add an nginx or other redirect if we need to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatten destination filters doc path
cc @nzoschke