feat(): Add integration-foot content to destination pages #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sanscontext I would need your approval here as after merging this content will be doubled on pages where its also included in the markdown file It's required to remove include that @bartlomiej-krakowski showing above? Do we also have to do that? Xavier added this lines yesterday and we not sure now |
jedrzejchalubek
approved these changes
Nov 22, 2019
|
Approved! We can remove the manually-added includes ourselves - we were doing that in case we couldn't get it working. (All of those empty files were created as a placeholder for new destinations that don't have any docs yet.) |
sanscontext
approved these changes
Nov 22, 2019
sanscontext
reviewed
Nov 22, 2019
| @@ -1,4 +1,3 @@ | |||
| <hr/> | |||
There was a problem hiding this comment.
Aha! Thank you! I couldn't figure out where that was coming from!
sanscontext
reviewed
Nov 22, 2019
sanscontext
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #283
Note:
Please check out integrations files, because in some of these is included
integration-foot.mdfile.