Skip to content

Updating the casing for the messageid field #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

forstisabella
Copy link
Contributor

Proposed changes

Fixed the way the messageid field appeared in the Warehouse/Data Lake deduplication docs. Corrected from message_id to messageId.

Merge timing

ASAP

Related issues (optional)

Closes #3194.

@forstisabella forstisabella requested a review from a team as a code owner July 12, 2022 15:58
@forstisabella forstisabella requested review from stayseesong and removed request for a team July 12, 2022 15:58
@markzegarelli markzegarelli merged commit 801b5c0 into develop Jul 12, 2022
@markzegarelli markzegarelli deleted the message-deduplication-update branch July 12, 2022 16:54
@markzegarelli markzegarelli added the content-update updates to content that are not new features, includes grammar fixes, added notes label Jul 12, 2022
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

markzegarelli pushed a commit that referenced this pull request Jul 12, 2022
* device mode improvements

* Update src/connections/sources/catalog/libraries/mobile/react-native/index.md

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Update src/connections/destinations/catalog/firebase/index.md

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Updated description of the way Segment calculates timestamps

* Update index.md

Updated the date from June 2 > July 8, 2022

Re-ordered a few items in the tables, but mostly just renamed events after we made the client side > server side switch, we consolidated a few events so now "Training" > "Content" and "Content Started" covers courses that could be started from a course collection, path or certificate which is more in line with the way the data is captured in our own internal reporting. 

We lost the ability to track "Exits Course" as this was a navigation item, so that was removed. Also I am unable to get details on E-Commerce, so those were removed as well. 

Minor tweaks to Event Properties table: adding user. in front of id, email, name. We also aren't doing anything with email subjects, I believe that was errantly carried over from the HackMD template.

* Removed the email section from the public beta flag from the Google Cloud Storage destination

* Update src/connections/storage/catalog/google-cloud-storage/index.md

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Updated the way that the integrations object handles All: false (#3190)

* Document support for Hubspot destination with  EU endpoints (#3199)

* Add Personas Connections Clarification #2948

* Add Source Function Alphabetization FAQ DOC-536

* FAQs for upgrading to A.js 2.0 [netlify-build]

* Update index.md

* Update src/personas/audiences/index.md

Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>

* fixes

* remove DC 1.0 link

* small fix

* remove DC 1.0 link

* Apply suggestions from code review

* Heap (Actions) destination docs (#3187)

* Heap (Actions) documentation

* Edits

* Re-add version link

* Apply suggestions from code review

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

Co-authored-by: Gediminas Rapolavicius <gediminas.rap@gmail.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* catalog update (#3210)

* Updating the casing for the messageid field (#3206)

Co-authored-by: Niall Brennan <niall.brennan@segment.com>
Co-authored-by: Niall Brennan <niallbrennan87@gmail.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: Segment Docs Robot <73141528+bot-docsteam@users.noreply.github.com>
Co-authored-by: Jessie Tully <jessietully@gmail.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: pwseg <paul.wooley@segment.com>
Co-authored-by: stayseesong <STACY.S.SONG@GMAIL.COM>
Co-authored-by: Bhavik Patel <Bhavik-P@users.noreply.github.com>
Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
Co-authored-by: Gediminas Rapolavicius <gediminas.rap@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Content]: conflicting information about which field is used for message deduplication
2 participants