Skip to content

Add links to Full Segment Implementation #4110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Conversation

sarahrudy
Copy link
Contributor

Add useful links to Full Segment Implementation

Proposed changes

  • Added some useful links where they belong next to identify and track calls, respectively
  • Kept naming convention of track, identify, screen, page consistent throughout page

Merge timing

  • ASAP once approved

@sarahrudy sarahrudy added the KCS label Jan 23, 2023
@sarahrudy sarahrudy changed the title Add useful links to Full Segment Implementation Add links to Full Segment Implementation Jan 24, 2023
@sarahrudy sarahrudy marked this pull request as ready for review January 24, 2023 22:26
@sarahrudy sarahrudy requested a review from a team as a code owner January 24, 2023 22:26
@sarahrudy sarahrudy requested review from pwseg and removed request for a team January 24, 2023 22:26
@markzegarelli
Copy link
Contributor

Hey @sarahrudy. In our Style Guide, we have guidance around how to refer to specific methods (Track call, not track).

Can you update this PR to remove instances where you've made these changes?

@sarahrudy
Copy link
Contributor Author

Hi @markzegarelli, I just made those changes you requested and committed them to sarahrudy-patch-4.

@pwseg pwseg requested a review from markzegarelli January 25, 2023 22:25
Copy link
Contributor

@markzegarelli markzegarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We like to use relative URLs in links to other pages on Segment Docs. This make things easier if we ever change the site's domain.

@markzegarelli markzegarelli merged commit 50915db into develop Jan 26, 2023
@markzegarelli markzegarelli deleted the sarahrudy-patch-4 branch January 26, 2023 17:03
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants