Skip to content

Loops (Actions) Destination #5455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 4, 2023
Merged

Loops (Actions) Destination #5455

merged 10 commits into from
Oct 4, 2023

Conversation

forstisabella
Copy link
Contributor

Proposed changes

Moved docs from original PR to editable PR.

Merge timing

After approval by tcgilbert, docs

Related issues (optional)

#5451

@forstisabella forstisabella requested a review from a team as a code owner September 29, 2023 21:37
@forstisabella forstisabella requested review from rchinn1 and removed request for a team September 29, 2023 21:37
@forstisabella forstisabella added the new-integration Added a new source or destination label Sep 29, 2023
Copy link
Contributor

@rchinn1 rchinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forstisabella left a few suggestions in addition to what you've already commented on

forstisabella and others added 2 commits October 2, 2023 13:07
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
@forstisabella forstisabella requested a review from rchinn1 October 2, 2023 17:09
Copy link
Contributor

@rchinn1 rchinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@forstisabella
Copy link
Contributor Author

hey @tcgilbert - could you take a look at this one when you get a chance?

Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@forstisabella forstisabella merged commit e0b55a1 into develop Oct 4, 2023
@forstisabella forstisabella deleted the pr/5451 branch October 4, 2023 16:06
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants