Fueled/shopify fueled #5677
Fueled/shopify fueled #5677
Conversation
Partial first pass
Rounding out documentation.
src/connections/sources/catalog/cloud-apps/shopify-fueled/index.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/cloud-apps/shopify-fueled/index.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/cloud-apps/shopify-fueled/index.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/cloud-apps/shopify-fueled/index.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/cloud-apps/shopify-fueled/index.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/cloud-apps/shopify-fueled/index.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/cloud-apps/shopify-fueled/index.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/cloud-apps/shopify-fueled/index.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/cloud-apps/shopify-fueled/index.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/cloud-apps/shopify-fueled/index.md
Outdated
Show resolved
Hide resolved
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
|
@stayseesong - Thank you for the review. There's one open issue, but I've committed all of the other suggestions. Let me know next steps. Really appreciate how prompt this process has been!! This is great!!! |
There was a problem hiding this comment.
Just add the frontmatter, and address @stayseesong 's comments, and we should be all set!
src/connections/sources/catalog/cloud-apps/shopify-fueled/index.md
Outdated
Show resolved
Hide resolved
…x.md Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
|
Updated. Hopfully ready to go!! Thanks, team!! |
|
Actually, @tcgilbert - Not sure why the PR is listed as still blocked b/c of pending change requests. Mind taking a look? |
|
@seanberto there are a number requested changes when you navigate here. Are you seeing what I see? 
|
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
|
@tcgilbert - I think I've not resolved those issues, but the merge is still blocked. |
|
I'm happy with all of your edits, @tcgilbert . |
src/connections/sources/catalog/cloud-apps/shopify-fueled/index.md
Outdated
Show resolved
Hide resolved
|
@tcgilbert - I accidentally asked @stayseesong for an additional review. Sorry. Also, not sure how to address the question about "our" above. I was referring to Fueled's library. Can you suggest a commit? |
src/connections/sources/catalog/cloud-apps/shopify-fueled/index.md
Outdated
Show resolved
Hide resolved
…x.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
|
@tcgilbert and @stayseesong - I believe I have reviewed all change reqeusts, but the merging is still blocked. Not sure what I need to do. |
|
I will be able to merge it after I approve. All of our PRs need approval from the docs team in order to merge, and the docs team is in charge of merging all requests |
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
Documenting Fueled's Shopify Source integration for Segment.
Merge timing