Skip to content

add docs for new movable ink destination #5720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 28, 2023
Merged

add docs for new movable ink destination #5720

merged 4 commits into from
Nov 28, 2023

Conversation

tcgilbert
Copy link
Contributor

Proposed changes

add docs for new movable ink destination

Merge timing

asap

@tcgilbert tcgilbert requested a review from a team as a code owner November 22, 2023 15:19
@tcgilbert tcgilbert requested review from rchinn1 and removed request for a team November 22, 2023 15:19
@rchinn1
Copy link
Contributor

rchinn1 commented Nov 22, 2023 •
edited
Loading

@tcgilbert content lgtm - Just flagging a few things I noticed in my local build:

  • The Destination info box is empty
    Destination-info-empty

  • There's also a typo ("visble") auto-populated from our actions-fields.html file. I've merged a separate PR to address this.
    typo

@pwseg pwseg added the new-integration Added a new source or destination label Nov 28, 2023
@pwseg pwseg enabled auto-merge November 28, 2023 17:46
@pwseg pwseg disabled auto-merge November 28, 2023 17:46
@pwseg pwseg merged commit 3f11fda into develop Nov 28, 2023
@pwseg pwseg deleted the thomas/movable-ink branch November 28, 2023 17:46
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-ayoub-segment joe-ayoub-segment joe-ayoub-segment requested changes

@rchinn1 rchinn1 rchinn1 approved these changes

Assignees
No one assigned
Labels
new-integration Added a new source or destination
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcgilbert @rchinn1 @joe-ayoub-segment @pwseg