Skip to content

Added a small formatting change to the ProfitWell doc #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2020
Merged

Added a small formatting change to the ProfitWell doc #660

merged 3 commits into from
Feb 26, 2020

Conversation

gezgblack
Copy link
Contributor

Fixing a small change that I missed in the ProfitWell doc.

@gezgblack
Copy link
Contributor Author

@sanscontext

@sanscontext
Copy link
Contributor

Nice! Just remember to delete your branch now that it's merged.

sanscontext
sanscontext reviewed Feb 25, 2020
View reviewed changes
Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this formatting change?

@gezgblack
Copy link
Contributor Author

gezgblack commented Feb 25, 2020 •
edited
Loading

What's the purpose of this formatting change?

The purpose is that its missing an opening underscore in order to create the note field in Italic

This is how it looks currently:
image

This is how it looks after the change:
image

@sanscontext
Copy link
Contributor

Right, I guess my question is why we're not using the new format.

(Also, looking at this, you need to add "Destination" to the end of the title please.)

@gezgblack
Copy link
Contributor Author

Right, I guess my question is why we're not using the new format.

(Also, looking at this, you need to add "Destination" to the end of the title please.)

That's because I was following the format set in the catalog template https://hackmd.io/t7amLXluS7-39rg7ARZgSA?both it too isn't updated to the new format.

@gezgblack
Copy link
Contributor Author

Addressed the issues you raised @sanscontext 😉

@sanscontext
Copy link
Contributor

Thanks @gezgblack ! I also updated the partner template. (Do you gents not have access? 🤔 )

sanscontext
sanscontext approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved!

@gezgblack gezgblack merged commit 757cba2 into master Feb 26, 2020
@gezgblack gezgblack deleted the ProfitWellSmallFix branch February 26, 2020 09:56
bot-docsteam added a commit that referenced this pull request Nov 3, 2022
@bot-docsteam
Merge pull request #660 from segmentio/repo-sync
7836844 
repo sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanscontext sanscontext sanscontext approved these changes

@benhorowitz benhorowitz Awaiting requested review from benhorowitz

@danielstjules danielstjules Awaiting requested review from danielstjules

@n2parko n2parko Awaiting requested review from n2parko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gezgblack @sanscontext