-
Notifications
You must be signed in to change notification settings - Fork 363
feat(): Introduce side by side buttons #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks fine to me. I'm not clear if there are any gotchas or issues with using So just to make sure I understand what this does, wrapping a pair of buttons in |
Ohh I'm sorry, I must have missed your comment here @sanscontext. Well, that's right - I couldn't place them next to each other without any wrapper element. CSS Maybe I'll show you a different solution 🤔
inside the However, it's totally up to you now. I'm not going to use this element that much. |
Let's keep it with the div tag! I think that's much easier to use - was just making sure I understood what was built in case there were questions later. :) |
Gah, sorry, I thought I merged this! Doing that now. |
Proposed changes
I hope that
<div>
element won't be a big problem for you. Couldn't find any reasonable solution for this issue.I change the "Media Icons" heading to "Reference Buttons" in the styleguide. I'm not sure if that's entirely correct, but media icons seemed to be something other than buttons.
Related issues (optional)
Closes: #661