Update index.md #673
Merged
Update index.md #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Welcome welcome! I'm going to review this now. |
sanscontext
suggested changes
Mar 2, 2020
|
|
||
| This limitation requires that customers include a native Optimizely snippet or implementation before their Segment snippet or implementation on pages or in mobile apps where Optimizely experiments run. | ||
| Although Segment maps `track`, and in some cases `page`, events to Optimizely's `track` method, customers must implement all Optimizely decision-based methods, such as `activate`, `isFeatureEnabled`, etc., natively. Segment's API does not include methods that correspond to decision-based methods. |
There was a problem hiding this comment.
Is there a link to a list of these "decsion-based methods"? Might be useful for readers to review.
|
I confirmed with the team that we don't have anyone still using the old version who might get stranded without additional instructions, so dismissing those threads. The last item is a nice-to have, but not required. |
sanscontext
approved these changes
Mar 3, 2020
|
Can we get this merged in @sanscontext? I sent over the signed document |
|
Hey @Danny-Driscoll sorry for the delay - I just saw your email with the signed doc. Having to rebuild to make sure it passes CI, then we're golden! Should take about ~10 minutes all told. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removing references to Optimizely Classic from the Optimizely Web destination docs since the product has been fully sunsetted, and it had been pushing currently-relevant content further down the page.
Also added some context to the introduction section about why Optimizely libraries need to be implemented natively vs. pulled in by segment
Related issues (optional)