Skip to content

[DG-573] Add description field to entities/relationships #7600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

LLuque-twilio
Copy link

@LLuque-twilio LLuque-twilio commented May 2, 2025

Proposed changes

This PR implements DG-573

In it we add a new description field to entities & relationships and update HCL examples in Data Graph docs.

Merge timing

When should this get merged/published?

  • ASAP once approved? ✅

Related issues (optional)

@LLuque-twilio LLuque-twilio requested review from pwseg and a team as code owners May 2, 2025 19:14
Copy link

netlify bot commented May 2, 2025

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit e43dd94
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/681519a7c9ca820008bf13ca
😎 Deploy Preview https://deploy-preview-7600--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stayseesong stayseesong self-requested a review May 2, 2025 19:48
Comment on lines +5 to +6
- "/unify/linked-profiles/data-graph"
- "/unify/data-graph/data-graph"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "/unify/linked-profiles/data-graph"
- "/unify/data-graph/data-graph"
- '/unify/linked-profiles/data-graph'
- '/unify/data-graph/data-graph'

| Parameters | Definition |
| ------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `entity` | An immutable slug for the entity, and will be treated as a delete if you make changes. The slug must be in all lowercase, and supports dashes or underscores (e.g `account-entity` or `account_entity`). |
| (Optional) `description` | An optional descriptor used to add additional context to the entity |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| (Optional) `description` | An optional descriptor used to add additional context to the entity |
| `description` (*Optional*) | An optional descriptor used to add additional context to the entity. |

| ------------------------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `relationship` | An immutable slug for the relationship, and will be treated as a delete if you make changes. The slug must be in all lowercase, and supports dashes or underscores (like `user-account` or `user_account`) |
| `name` | A label displayed throughout your Segment space for Linked Events, Linked Audiences, etc. This name can be modified at any time |
| (Optional) `description` | An optional descriptor used to add additional context to the relationship |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| (Optional) `description` | An optional descriptor used to add additional context to the relationship |
| `description` (*Optional*) | An optional descriptor used to add additional context to the relationship. |

| ------------------------ | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `relationship` | An immutable slug for the relationship, and will be treated as a delete if you make changes. The slug must be in all lowercase, and supports dashes or underscores (like `user-account` or `user_account`) |
| `name` | A label displayed throughout your Segment space for Linked Events, Linked Audiences, and so on. This name can be modified at any time |
| (Optional) `description` | An optional descriptor used to add additional context to the relationship |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| (Optional) `description` | An optional descriptor used to add additional context to the relationship |
| `description` (*Optional*) | An optional descriptor used to add additional context to the relationship. |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants