Skip to content

Conversation

motasem-userpilot
Copy link
Contributor

@motasem-userpilot motasem-userpilot commented Jul 28, 2025

Proposed changes

Adding documentation for Segment x Userpilot mobile integration

Merge timing

ASAP

@motasem-userpilot motasem-userpilot requested a review from a team as a code owner July 28, 2025 12:56
@stayseesong stayseesong added the new-integration Added a new source or destination label Jul 28, 2025
@joe-ayoub-segment
Copy link
Contributor

Hi @motasem-userpilot ,

Can you please clarify which Segment Integration this doc is for?

Thank you ,
Joe

@motasem-userpilot
Copy link
Contributor Author

Hey @joe-ayoub-segment

This documentation is for a Device-Mode Mobile Destination that supports iOS, Android, and React Native platforms.

Thanks,
Motasem

@joe-ayoub-segment
Copy link
Contributor

Thanks @motasem-userpilot . Can you point to the source code for this Integration please?

@motasem-userpilot
Copy link
Contributor Author

@joe-ayoub-segment
Copy link
Contributor

Thanks for confirming @motasem-userpilot .

Hi @stayseesong I'm not the correct technical resource to review this PR. I recommend asking someone from the Mobile SDK team to look at it. I only work with Web and Cloud Mode Integrations.

wenxi-zeng
wenxi-zeng previously approved these changes Jul 30, 2025
bsneed
bsneed previously approved these changes Jul 31, 2025
@bsneed
Copy link
Contributor

bsneed commented Jul 31, 2025

LGTM! Nicely done plugin.

@joe-ayoub-segment
Copy link
Contributor

LGTM! Nicely done plugin.

Thanks for looking at this @bsneed !

@stayseesong
Copy link
Contributor

@bsneed @joe-ayoub-segment is there a destination ID that needs to accompany this mobile destination? Normally for all of our other destinations that get added onto the docs site, there's a destination ID that needs to be added in.

@bsneed
Copy link
Contributor

bsneed commented Aug 1, 2025

@bsneed @joe-ayoub-segment is there a destination ID that needs to accompany this mobile destination? Normally for all of our other destinations that get added onto the docs site, there's a destination ID that needs to be added in.

Not sure on that. I see some Userpilot entries in the destination list in the app, but not familiar with the ID aspect.

@joe-ayoub-segment
Copy link
Contributor

@bsneed @joe-ayoub-segment is there a destination ID that needs to accompany this mobile destination? Normally for all of our other destinations that get added onto the docs site, there's a destination ID that needs to be added in.

Hi @stayseesong I don't know. I've not ever contributed to any mobile work.

@ThabetIbrahim
Copy link
Contributor

Hi @joe-ayoub-segment and Team,

I believe the ID will be available once the destination is approved. We have created a new destination using the Segment developer dashboard (Userpilot Mobile), which is currently under review.

Based on a previous conversation with the partnership team, they advised us to self-host our plugins for mobile and create a destination entry to manage the integration.

@joe-ayoub-segment
Copy link
Contributor

estination is approved. W

Hi @ThabetIbrahim !
Thanks for filling in the blanks. With this new info I was now able to find the ID: 68207e064c022255721ec2d3
FYI @stayseesong .

Best regards,
Joe

@ThabetIbrahim
Copy link
Contributor

No problem @joe-ayoub-segment! Happy to help.

@stayseesong
Copy link
Contributor

@joe-ayoub-segment am I good to merge this in or do I need to wait for anything else?

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
@stayseesong stayseesong merged commit 444e384 into segmentio:develop Aug 7, 2025
2 checks passed
Copy link
Contributor

github-actions bot commented Aug 7, 2025

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

@joe-ayoub-segment
Copy link
Contributor

Hi @stayseesong - I'm not across this Integration at all (I just work on web and cloud mode stuff). Looks like it's merged now anyway ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants