Skip to content

Conversation

arnav777dev
Copy link
Contributor

@arnav777dev arnav777dev commented Jul 31, 2025

Proposed changes

A customer reached out letting us know that the Kinesis Firehose destination is missing a description for the mixed setting. Raised the question in the #questions-destinations Slack channel

Added empty array check to defaultValue condition in destination footer

  • Add check for '[]' to prevent displaying "defaults to" text for empty arrays

Merge timing

  • ASAP once approved

Closes #5673

@arnav777dev arnav777dev requested a review from a team as a code owner July 31, 2025 15:18
@arnav777dev arnav777dev requested a review from stayseesong July 31, 2025 15:18
@forstisabella
Copy link
Contributor

forstisabella commented Jul 31, 2025

HI @arnav777dev - when I build the site locally it's still broken.

Screenshot 2025-07-31 at 12 52 13 PM

@arnav777dev
Copy link
Contributor Author

Hey @stayseesong,
I added a quick debug line to inspect the defaultValue:
<p style="color:red;">DEBUG: '{{ item.defaultValue }}' (type: {{ item.type }})</p>
As seen in the attached screenshot, it appears to be empty ""— but the condition
{% if item.defaultValue != null and item.defaultValue != "" and item.defaultValue != '{}' and item.defaultValue != '[]'%}
still evaluates as true, leading to an output like defaults to ., which might not be ideal.

Screenshot 2025-08-01 at 11 21 22 AM

I’m not too familiar with Liquid quirks here — maybe someone closer to the docs setup might spot what’s going on.
cc - @forstisabella
Thanks!

@forstisabella
Copy link
Contributor

hi @arnav777dev - I'll take a look and see if I can figure out what's going on. In the meantime: the Slack thread mentioned this might need to be updated to be a required setting. Are you able to do that on your end?

@forstisabella
Copy link
Contributor

hi @arnav777dev - see the screenshot below, I think we fixed it! 🥳

Screenshot 2025-08-01 at 3 14 46 PM

@stayseesong stayseesong added the fixed-content fix to content that has outdated or wrong information label Aug 1, 2025
@stayseesong
Copy link
Contributor

@forstisabella hmm am I doing something wrong? When I run it locally, I don't see the fix

@forstisabella
Copy link
Contributor

hi @stayseesong you may just need to close and then rebuild the local site, as anything in a folder that begins with a _ doesn't automatically rebuild if you save the file or switch from branch to branch!

@stayseesong stayseesong merged commit b99a151 into develop Aug 5, 2025
4 checks passed
@stayseesong stayseesong deleted the STRATCONN-6101/wrong-description branch August 5, 2025 16:54
Copy link
Contributor

github-actions bot commented Aug 5, 2025

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Content]: Missing description of the mixed setting for Kinesis Firehose
3 participants