Skip to content

Conversation

sade-wusi
Copy link
Contributor

Proposed changes

Applied Twilio style guide changes.
General review, tweaks to wording, casing and layout of HTML.

Merge timing

  • ASAP

@sade-wusi sade-wusi requested a review from a team as a code owner September 1, 2025 16:46
@sade-wusi sade-wusi requested a review from rchinn1 September 1, 2025 16:46
@sade-wusi sade-wusi added the content-update updates to content that are not new features, includes grammar fixes, added notes label Sep 1, 2025
Copy link

netlify bot commented Sep 1, 2025

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit d2f14de
🔍 Latest deploy log https://app.netlify.com/projects/segment-docs/deploys/68b5f63b5c255d000841605d
😎 Deploy Preview https://deploy-preview-7867--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

rchinn1
rchinn1 previously approved these changes Sep 3, 2025
Copy link
Contributor

@rchinn1 rchinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this, @sade-wusi! By no means a blocker, but left a tiny suggestion to simplify the success boxes.

Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
@sade-wusi sade-wusi requested a review from rchinn1 September 3, 2025 15:28
Copy link
Contributor

@rchinn1 rchinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sade-wusi sade-wusi merged commit 54cdc00 into develop Sep 3, 2025
4 checks passed
@sade-wusi sade-wusi deleted the basic-seg-install-audit branch September 3, 2025 17:01
Copy link
Contributor

github-actions bot commented Sep 3, 2025

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants