A Full Segment Implementation review #7941
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sade-wusi
reviewed
Sep 12, 2025
| - **Enabled/Disabled** - Enabling or disabling some feature (e.g., audible alarms, emails, etc). | ||
| - **Created/Deleted** - The user- or system-initiated action of creating or deleting an object (for example, new search, favorite, post). | ||
| - **Displayed/Hidden** - The user- or system-initiated action of hiding or displaying an element. | ||
| - **Enabled/Disabled** - Enabling or disabling some feature (For example, audible alarms, or emails). |
There was a problem hiding this comment.
Suggested change
| - **Enabled/Disabled** - Enabling or disabling some feature (For example, audible alarms, or emails). | |
| - **Enabled/Disabled** - Enabling or disabling some feature (for example, audible alarms, or emails). |
sade-wusi
reviewed
Sep 12, 2025
| - **Unposted** - Making a previously publicly-viewable posting private. | ||
| - **Updated** - The user action that initiates an update to an object (profile, password, search, etc.; typically be making a call to the backend), or the they system having actually completed the update (often this tracking call will be made in response to a server-side response indicating that the object was updated, which may or may not have an impact on the UI). | ||
| - **Viewed** - (exactly what it says on the tin) | ||
| - **Updated** - The user action that initiates an update to an object (profile, password, or search); typically be making a call to the backend, or the the system having actually completed the update (often this tracking call will be made in response to a server-side response indicating that the object was updated, which may or may not have an impact on the UI). |
There was a problem hiding this comment.
Suggested change
| - **Updated** - The user action that initiates an update to an object (profile, password, or search); typically be making a call to the backend, or the the system having actually completed the update (often this tracking call will be made in response to a server-side response indicating that the object was updated, which may or may not have an impact on the UI). | |
| - **Updated** - The user action that initiates an update to an object (profile, password, or search). This might be a backend call or the system completing an update. This tracking call is often made in response to a server-side response indicating that the object was updated (which may or may not have an impact on the UI). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Reviewed step 4 in the getting started series for the docs audit project.
Merge timing
asap
Related issues (optional)