Skip to content

clean up build command #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2019
Merged

clean up build command #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
steps:
- label: ":hammer: Build Dependencies"
command:
- npm config set "//registry.npmjs.org/:_authToken" $${NPM_TOKEN}
- yarn install --frozen-lockfile
- chown -R jekyll /workdir
- make build
env:
SEGMENT_CONTEXTS: "snyk,npm"
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ intialize-work-dir:

.PHONY: build
build: node_modules vendor/bundle
# @bundle exec rake catalog:update
@chown -R jekyll /workdir
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the need for this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jekyl docker container has some permission issues due to the default User identity it uses: envygeeks/jekyll-docker#116
Updating the permissions on the working directory resolves permission issues with running commands in working dir.

@$(BIN)/webpack --mode=production
@JEKYLL_ENV=${JEKYLL_ENV} bundle exec jekyll build

Expand Down