Skip to content

Replace href links in the landing section #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/_data/landing.yml
Original file line number Diff line number Diff line change
@@ -1,31 +1,39 @@
- name: Guides
icon: icon-guides.svg
description: "Start here! Best practices, Setup steps, and other useful information."
path: /guides

- name: Academy
icon: icon-academy.svg
description: "Learn more about the 'whys' and 'hows' of analytics. A great read if you're just getting started."
path: /academy

- name: App
icon: icon-app.svg
description: "Learn your way around the Segment web application - hook up data sources to tools and warehouses, set up filtering, and more."
path: /app

- name: Connections
icon: icon-connections.svg
description: "Collect data once, and integrate tools for analytics, growth, marketing and more."
path: /connections

- name: Protocols
icon: icon-protocols.svg
description: "Prevent data quality issues before they start with a tracking schema and data quality enforcement."
path: /protocols

- name: Personas
icon: icon-personas.svg
description: "Improve your interactions by building audiences to personalize experiences."
path: /personas

- name: Privacy
icon: icon-privacy.svg
description: "Respect your customers’ privacy with tools for data discovery and policy enforcement."
path: /privacy

- name: Partners
icon: icon-partners.svg
description: "Join the Segment Platform and enable thousands of companies to activate their first party data."
path: /partners
2 changes: 1 addition & 1 deletion src/_includes/components/media-icon.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="media-icon media-icon--{{ include.variant }}">
<a class="media-icon__inner" href="{{ include.href }}">
<a class="media-icon__inner" href="{{ site.baseurl }}{{ include.href }}">
<span class="media-icon__icon">
{% include icons/media/{{ include.icon }} %}
</span>
Expand Down
9 changes: 1 addition & 8 deletions src/_includes/landing.html
Original file line number Diff line number Diff line change
@@ -1,14 +1,7 @@
<div class="flex flex--wrap waffle waffle--large">
{% for category in site.data.landing %}
{% assign url = category.name | downcase %}

{% if url contains "app" %}
{% assign url = url | replace: "app", "segment-app" %}
{% assign category_href = url | relative_path %}
{% endif %}

<div class="flex__column flex__column--6">
{% include components/media-icon.html variant="small" href=category_href icon=category.icon title=category.name content=category.description %}
{% include components/media-icon.html variant="small" href=category.path icon=category.icon title=category.name content=category.description %}
</div>
{% endfor %}
</div>