Added clarification on video content position / total length #993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanscontext
reviewed
Jul 8, 2020
|
This looks good to me with a minor copy edit, but I'm not sure how to validate that this is true? Is there someone we can tag here to confirm? |
|
@Isuru-F To confirm, this is only updating the |
Co-authored-by: LRubin <sanscontext@users.noreply.github.com>
|
Hey folks, I'll merge this EOD unless someone has an objection. |
sanscontext
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updating Video Spec Content vs Playback property descriptions on position and total_length to reflect the following
1 - Content * properties = Properties on the Asset (excluding Ads)
2 - Playback* properties = Properties on the Playback (Asset + ads)
3 - Ads* Properties = Properties on the Ad Asset.
If the above is true #1 has a bug in the docs that this PR will address.
Merge timing
Related issues (optional)