This repository was archived by the owner on Jan 15, 2021. It is now read-only.
Make install instructions more clear. #137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it more clear how to install this in a project which uses Composer. Apparently it's enough to have this package in your dependencies but the install instructions from the readme weren't clear on this. https://symfony.com/doc/current/setup.html#checking-for-security-vulnerabilities
fabpot
reviewed
Nov 26, 2018
| @@ -23,6 +23,8 @@ Integration | |||
| The checker uses the Symfony Console component; so, you can easily integrate | |||
| the checker into your own project: | |||
|
|
|||
| * by requiring it with Composer: `composer require ensiolabs/security-checker --dev`: https://symfony.com/doc/current/setup.html#checking-for-security-vulnerabilities | |||
There was a problem hiding this comment.
I would not recommend it as your project deps can interfere with the checker ones.
There was a problem hiding this comment.
But it's in Symfony's own docs? Does it need to be removed from those docs then if you don't recommend it?
There was a problem hiding this comment.
It needs to be removed everywhere. It's the default value, so there is no need to be explicit here.
There was a problem hiding this comment.
Okay I'll send in a PR to remove it from the Symfony docs 👍
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 30, 2018
This PR was merged into the 4.1 branch. Discussion ---------- Don't recommend requiring with Composer See discussion here: sensiolabs/security-checker#137 (review) Commits ------- 801645f Don't recommend requiring with Composer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it more clear how to install this in a project which uses Composer. Apparently it's enough to have this package in your dependencies but the install instructions from the readme weren't clear on this.
https://symfony.com/doc/current/setup.html#checking-for-security-vulnerabilities