fix: support module namespaces for node.js #10105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10105 +/- ##
==========================================
- Coverage 85.39% 85.26% -0.13%
==========================================
Files 334 334
Lines 13604 13648 +44
==========================================
+ Hits 11617 11637 +20
- Misses 1987 2011 +24
Continue to review full report at Codecov.
|
6e02033 to
986b495
Compare
There was a problem hiding this comment.
Thanks a lot @dnalborczyk - it looks good in general, however the tests should be using runServerless based approach as we're slowly migrating old tests to it and not allow introduction of new tests written the "old way". Would you be able to adjust them?
EDIT: Looks like there are some failing tests
| @@ -414,8 +414,90 @@ describe('AwsInvokeLocal', () => { | |||
|
|
|||
| describe('for different handler paths', () => { | |||
| [ | |||
| { path: 'handler.hello', expected: 'handler' }, | |||
| { path: '.build/handler.hello', expected: '.build/handler' }, | |||
| { | |||
There was a problem hiding this comment.
We should not expand the old-style tests but rather all new ones should use runServerless-based approach
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #10105 +/- ##
==========================================
- Coverage 85.39% 85.26% -0.13%
==========================================
Files 334 334
Lines 13604 13648 +44
==========================================
+ Hits 11617 11637 +20
- Misses 1987 2011 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes: #10091
for future reference: with this commit, once released, we could potentially add the RIC to the dependencies and call the handler directly.