Skip to content

Add buildOptions to ECR config #12360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add buildOptions to ECR config #12360

wants to merge 4 commits into from

Conversation

martinezpl
Copy link

Adds a buildOptions parameter to ECR config block in order to enable passing arbitrary flags to the docker build command, which builds the image that is sent to ECR.

e.g.

provider:
  ecr:
    scanOnPush: true
    images:
      image:
        path: ./image/
        file: Dockerfile.dev
        buildArgs:
          STAGE: ${sls:stage}
        buildOptions:
          [
            '--tag',
            'v1.0.0',
            '--add-host',
            'example.com:0.0.0.0',
            '--ssh',
            'default=/path/to/private/key/id_rsa',
          ]

Closes: #11255, #10712

@insidewhy insidewhy mentioned this pull request Apr 14, 2024
Open
@CoderSpinoza
Copy link

@martinezpl Is there a plan to merge this? I think this could be beneficial to many users.

@martinezpl
Copy link
Author

@CoderSpinoza I agree, but it's a question for the maintainers. Issues and PRs coming from outsiders used to be actively reviewed and merged in here, but something seems to have changed this year and the current maintainers ignore those completely.

@austencollins
Copy link
Member

I think we can get this in shortly. Adding it to our list..

@austencollins
Copy link
Member

This functionality has been added in: https://github.com/serverless/serverless/releases/tag/v4.1.4 cc @CoderSpinoza

@BrewTestBot BrewTestBot mentioned this pull request Jun 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOCKER Expose SSH Argument. (Secrets Flag)
3 participants
@martinezpl @CoderSpinoza @austencollins