feat(AWS Lambda): Add support for secrets to images (#12427)
#12428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secrets to images (#12427)`secrets to images (#12427)
insidewhy
commented
Apr 14, 2024
|
@eahefnawy @ac360 and @Mmarzex please take a gander at this small PR to boost docker capability |
|
I see that #12360 has finally been merged, that will help a lot, the workarounds for dealing with secrets without having access to build options (or this PR) were so frustrating. I think having a specific option for it like this would be useful also but it's not as essential now there's a different way of dealing with it. It took a long time for that PR to get merged, not having that or this PR implemented caused a lot of difficulty for our team, we actually stopped using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12427
But #12360 would be good enough also if you don't mind opening up the possibility of arbitrary docker build arguments. There's precedence for this though i.e.
buildArgs.